Add Node and NodeList types to Rust RBS bindings #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
alexcrocha
force-pushed
the
Add_Node_and_NodeList_types_to_Rust_RBS_bindings
branch
from
1a88732 to
db77143
Compare
vinistock
approved these changes
Nov 18, 2025
alexcrocha
force-pushed
the
Add_Node_and_NodeList_types_to_Rust_RBS_bindings
branch
from
db77143 to
92b4b45
Compare
alexcrocha
changed the base branch from
11-13-handle_rbssymbol_types
to
graphite-base/57
alexcrocha
force-pushed
the
graphite-base/57
branch
from
5cc5122 to
3e8e1f0
Compare
alexcrocha
force-pushed
the
Add_Node_and_NodeList_types_to_Rust_RBS_bindings
branch
from
92b4b45 to
d95b29f
Compare
alexcrocha
changed the base branch from
graphite-base/57
to
ar-rust-rbs-build
alexcrocha
force-pushed
the
Add_Node_and_NodeList_types_to_Rust_RBS_bindings
branch
from
d95b29f to
e132ca3
Compare
alexcrocha
force-pushed
the
Add_Node_and_NodeList_types_to_Rust_RBS_bindings
branch
from
e132ca3 to
fc4ccf3
Compare
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Refactor node structs to use pointer-based access and add NodeList iterator Changes node generation from storing individual fields to holding a single pointer to the C struct. This avoids duplicating data in Rust structs and matches the pattern used in Prism's bindings. We just maintain a thin wrapper around the C pointer and dereference it in accessor methods. Adds NodeList/NodeListIter to enable idiomatic Rust iteration over RBS's linked list structures, and implements Node::new() factory method that type-checks the C node pointer and constructs the appropriate Rust variant with proper pointer casting. Also adds convert_name() helper to generate C identifiers from RBS node names (snake_case_t for types, UPPER_CASE for enum constants).
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Refactor node structs to use pointer-based access and add NodeList iterator Changes node generation from storing individual fields to holding a single pointer to the C struct. This avoids duplicating data in Rust structs and matches the pattern used in Prism's bindings. We just maintain a thin wrapper around the C pointer and dereference it in accessor methods. Adds NodeList/NodeListIter to enable idiomatic Rust iteration over RBS's linked list structures, and implements Node::new() factory method that type-checks the C node pointer and constructs the appropriate Rust variant with proper pointer casting. Also adds convert_name() helper to generate C identifiers from RBS node names (snake_case_t for types, UPPER_CASE for enum constants).
alexcrocha
added a commit
that referenced
this pull request
Jan 14, 2026
Refactor node structs to use pointer-based access and add NodeList iterator Changes node generation from storing individual fields to holding a single pointer to the C struct. This avoids duplicating data in Rust structs and matches the pattern used in Prism's bindings. We just maintain a thin wrapper around the C pointer and dereference it in accessor methods. Adds NodeList/NodeListIter to enable idiomatic Rust iteration over RBS's linked list structures, and implements Node::new() factory method that type-checks the C node pointer and constructs the appropriate Rust variant with proper pointer casting. Also adds convert_name() helper to generate C identifiers from RBS node names (snake_case_t for types, UPPER_CASE for enum constants).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored node structs to use pointer-based access and added NodeList iterator
Changed node generation from storing individual fields to holding a single pointer to the C struct. This avoids duplicating data in Rust structs and matches the pattern used in Prism's bindings. We just maintain a thin wrapper around the C pointer and dereference it in accessor methods.
Added
NodeList/NodeListIterto enable iteration over RBS's linked list structures, and implementedNode::new()factory method that type-checks the C node pointer and constructs the appropriate Rust variant with proper pointer casting.Also added
convert_name()helper to generate C identifiers from RBS node names (snake_case_t for types, UPPER_CASE for enum constants).